testing/synctest: document channel and timer violations as fatal - #80908
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Open
testing/synctest: document channel and timer violations as fatal#80908serhiy-bzhezytskyy wants to merge 1 commit into
serhiy-bzhezytskyy wants to merge 1 commit into
Conversation
The difference between a panic and a fatal panic is observable: recover cannot contain a fatal panic. A test that creates a channel inside a bubble and sends on it after the bubble has returned aborts the process, and a deferred recover never runs. CL 696195 changed bubble violations for channel and timer operations from regular panics to fatal panics, so that all bubble violations are consistently fatal. The package doc comment still says that operating on a bubbled channel, timer or ticker from outside the bubble panics. The neighboring sentences in the same section were updated to say "is a fatal error" in CL 675617, for WaitGroup.Add/Go and for Cond.Wait. This makes the channel, timer and ticker sentence agree with them. Updates golang#74837
Contributor
|
This PR (HEAD: 9ef34d1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/816240. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The difference between a panic and a fatal panic is observable: recover
cannot contain a fatal panic. A test that creates a channel inside a
bubble and sends on it after the bubble has returned aborts the
process, and a deferred recover never runs.
CL 696195 changed bubble violations for channel and timer operations
from regular panics to fatal panics, so that all bubble violations are
consistently fatal. The package doc comment still says that operating
on a bubbled channel, timer or ticker from outside the bubble panics.
The neighboring sentences in the same section were updated to say "is
a fatal error" in CL 675617, for WaitGroup.Add/Go and for Cond.Wait.
This makes the channel, timer and ticker sentence agree with them.
Updates #74837